-
Notifications
You must be signed in to change notification settings - Fork 0
+4,163,886
−1,475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master to dev
Merge dev to motif_estimation to bring branch up to date
Peak calling
…st line + improved documentation
Peak calling fixing the merging bug, changing the parameter name from max_bp_between to min_gap
I think we needed the better explanation for the problem with MOODS
…olab/masterJLU2018 into estimation_motifs
fixed .bed.bed unconsitent output name
Update README.md
HendrikSchultheis
requested review from
renewiegandt,
anastasiia,
JannikHamp and
SebastianBeyvers
January 13, 2019 13:17
SebastianBeyvers
previously approved these changes
Jan 13, 2019
SebastianBeyvers
approved these changes
Jan 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, don't bother my stupid comment from before. The 4 mio lines come from the original fasta file for chr1 of hg38.
Update README.md: Added step 4 of installation
renewiegandt
approved these changes
Jan 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pipeline runs. Approved.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.